Use the displayname of the groups#40229
Conversation
|
Just a note and link for reference: basic code to allow groups to have a display name was added in #26750 |
jvillafanez
force-pushed
the
use_group_displayname
branch
from
0e7c885 to
95a00aa
Compare
jvillafanez
changed the title
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Looks OK to me, and all tests pass. So we do not have any obvious mixup of group id and group name for core. And this is more progress supporting the ability to have the display name of a group different from the group id.
Needs review by some developer(s).
|
What happens about a changelog entry? |
|
I'll add a bugfix entry taking into account that this is mainly for ldap. |
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Changelog looks good. Let's merge this.
2 participants
Description
Use the displayname name of the group instead of the group id in multiple places. Currently checked in the user's list and in the personal settings.
Note that for regular (local) groups, the id and the displayname is the same, so there shouldn't be any noticeable changes.
The LDAP app will rely on this for further functionality (changes for LDAP in progress)
Related Issue
https://github.com/owncloud/enterprise/issues/5071
Motivation and Context
The group id must be immutable, as it is the user id. The group displayname should be shown instead, as the displayname can be changed at any point.
How Has This Been Tested?
Checked along with a specific patch for the user_ldap app.
Screenshots (if appropriate):
Types of changes
Checklist: