Description

https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode

https://www.php.net/manual/en/function.utf8-encode.php is being deprecated in PHP 8.2 and removed at some time in the future. I happened to notice this while looking at other things. There is an easy change to https://www.php.net/mb_convert_encoding so, IMO, we may as well do it now.

https://github.com/sabre-io/http/blob/master/CHANGELOG.md#500-alpha1-2018-02-16
Sabre\HTTP\URLUtil was removed back in 2018 and the code has changed anyway, so I removed the out-dated comment related to that.

I added a unit test case for filename pound-cent-AE-%A3%A2%C6-in-ISO-8859-1 - that has 3 ISO8859-1 "Latin-1" special characters in it. For that case, the code goes through the changed line and does produce the expected UTF-8 encoding. That unit test case passes with the previous code (I ran it manually), and still passes with the changed code. So there is not any obvious regression.

Related Issue

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE