Conversation
Contributor
|
@jvillafanez changelog pipeline complains: file changelog/unreleased/40143: title ends with punctuation, e.g. a character out of ".!?" |
96c66e8 to
933b087
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mmattel
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The missing js file was causing a crash in the js thread, preventing showing the action menu in public links. The crash is fixed and the menu shows up now.
Related Issue
https://github.com/owncloud/enterprise/issues/5166
Motivation and Context
The crash happen when the file is clicked, but before the expected popup menu is shown (
core/apps/files/js/filelist.js
Line 701 in 45c9aa5
How Has This Been Tested?
Install the pdf viewer and the collabora apps, and then follow the steps in the issue. A popup menu appears now.
Screenshots (if appropriate):
Types of changes
Checklist: