[tests-only] [full-ci] Adjust testPutSingleFileLegalMtime unit test cases#40101
Merged
phil-davis merged 1 commit intomasterfrom May 25, 2022
Merged
[tests-only] [full-ci] Adjust testPutSingleFileLegalMtime unit test cases#40101phil-davis merged 1 commit intomasterfrom
phil-davis merged 1 commit intomasterfrom
Conversation
phil-davis
requested review from
AlexAndBear,
DeepDiver1975,
JammingBen,
individual-it,
jvillafanez,
micbar and
xoxys
jvillafanez
approved these changes
May 25, 2022
Contributor
Author
|
https://drone.owncloud.com/owncloud/core/35849/36/5 |
11 tasks
Contributor
Author
|
One of the pipelines got the silly yarn pkg 501 "not implemented" error - very annoying. I restarted CI again. |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See the comment blocks that I added to the test code - they explain the new maximum positive and negative values being tested.
The "too long" test cases have been removed. Some file system implementations might support storing time stamps outside of the ext4-supported time stamp ranges (positive and/or negative). We don't require that an implementation does or does not support such time stamps - the results might (and are) different on different file system implementations. So don't try to test those.
Related Issue
How Has This Been Tested?
Local unit test run on Ubuntu 22.04 with PHP 7.4.29
CI
Types of changes
Checklist: