Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
The idea looks ok to me. Do we have any plans for adding more information in the "config" key? Otherwise, it seems better to use the "language" key directly. |
The code could return the "effective" language for the user. If the user has explicitly set a language, then return that. If the user has not set a language then return the system default language (which is the language that the user is going to be shown when they log in). There must already be a function somewhere for |
works |
d2aae78 to
02da19d
Compare
|
💥 Acceptance tests pipeline apiWebdavProperties2-mariadb10.2-php7.4 failed. The build has been cancelled. |
|
Kudos, SonarCloud Quality Gate passed! |
Fully agree, clients don't/shouldn't know or care where the language key comes from. They only need a value. The chain of fallbacks as proposed and implemented is perfect. 👍 (user choice -> system default -> hardcoded "en") |








Description
Requirement for:
owncloud/web#6243
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: