X Tutup
Skip to content

Display each app only once in app:list --minimal#40081

Merged
phil-davis merged 1 commit intomasterfrom
issue-39930
May 19, 2022
Merged

Display each app only once in app:list --minimal#40081
phil-davis merged 1 commit intomasterfrom
issue-39930

Conversation

@phil-davis
Copy link
Contributor

Description

Use the app name as an array key when building the lists of enabled and disabled apps in minimal view. That way each app can only end up once in the array.

Related Issue

How Has This Been Tested?

Put an app in both apps and apps-external folders. Then:
php occ app:list --minimal

Observe that the app is only listed once.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this May 17, 2022
@owncloud owncloud deleted a comment from update-docs bot May 17, 2022
@phil-davis phil-davis marked this pull request as ready for review May 17, 2022 15:53
@phil-davis phil-davis mentioned this pull request May 17, 2022
@owncloud owncloud deleted a comment from ownclouders May 17, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis marked this pull request as draft May 18, 2022 08:39
@phil-davis
Copy link
Contributor Author

phil-davis commented May 18, 2022

This is ready for merge. I set it to draft - it can be merged after release-10.10.0 is finalized and merged back to master.

@jnweiger
Copy link
Contributor

release-10.10.0 is finalized. Expect merge back to master tomorrow evening.

@phil-davis phil-davis marked this pull request as ready for review May 19, 2022 16:18
@phil-davis phil-davis merged commit c464ff4 into master May 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue-39930 branch May 19, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App duplicates

3 participants

X Tutup