Ignore thumbnails when propagating in home#39988
Merged
phil-davis merged 1 commit intomasterfrom Jun 18, 2022
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
jvillafanez
approved these changes
May 11, 2022
Contributor
|
someone needs to decide if this should be merged, and add a changelog describing what is the change/improvement. @micbar ? |
Contributor
|
fine for me |
butonic
force-pushed
the
ignore-thumbnails-when-propagating-in-home
branch
from
d78d27e to
87ef693
Compare
Contributor
|
💥 Acceptance tests pipeline apiAuth-mariadb10.2-php7.4 failed. The build has been cancelled. |
Contributor
|
@phil-davis mind to take a look why the accaptence test failed because of adding a changelog (ci was green before). We could merge when CI passes... |
Contributor
|
https://github.com/owncloud/core/tree/ignore-thumbnails-when-propagating-in-home The PR is so old - I will rebase. |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
phil-davis
force-pushed
the
ignore-thumbnails-when-propagating-in-home
branch
from
87ef693 to
2f9a17c
Compare
phil-davis
approved these changes
Jun 18, 2022
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
ignore-thumbnails-when-propagating-in-home
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thumbnails don't need to have their mtime propagated as already mentioned in #30320 (comment)
however the preview manager also listens on pre deletion hooks to build a list of affected files, so this only part of the problem and might not even be necessary when doing thumbnail eviction in a background cron job.
It might still be useful when generating thumbnails as we then don't have to propagate etag or size changes from the individual thumbnails up to the
thumbnailsfolder. A path likethumbnails/13245/44x44.pngthen would not have to do any propagation which helps when lots of pictures need to be thumbnailed, eg. when uploading a photo collection.