X Tutup
Skip to content

Revert fr _FR changes#39939

Merged
DeepDiver1975 merged 3 commits intomasterfrom
revert-fr_FR-changes
Apr 2, 2022
Merged

Revert fr _FR changes#39939
DeepDiver1975 merged 3 commits intomasterfrom
revert-fr_FR-changes

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 2, 2022

Description

  1. revert the temporary test changes done in PR disable fr related api acceptance tests because of #39931 #39934
  2. remove all fr_FR language translation files. They are no longer being pushed from Transifex. fr_FR has many fewer translations than the fr language code, so we want the system to use the fr translations when a user selects French.

We need to encourage translators on Transifex to do translations for fr and not fr_FR for core.

Link to Transifex commit that started all this: e285879

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis marked this pull request as ready for review April 2, 2022 07:33
@owncloud owncloud deleted a comment from update-docs bot Apr 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core CI start failing in apiTranslation suite

2 participants

X Tutup