X Tutup
Skip to content

emit correct legacy hook#39844

Merged
phil-davis merged 2 commits intomasterfrom
add-vs-update
Jun 15, 2022
Merged

emit correct legacy hook#39844
phil-davis merged 2 commits intomasterfrom
add-vs-update

Conversation

@butonic
Copy link
Contributor

@butonic butonic commented Mar 1, 2022 •
edited
Loading

shouldn't this be update instead of add?

just asking...

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis
Copy link
Contributor

phil-davis commented Jun 14, 2022

Someone needs to review this, and if the change is correct:

  • write something about what possible bug(s) this might fix
  • write a changelog

butonic and others added 2 commits June 15, 2022 09:11
@butonic @jvillafanez
emit correct legacy hook
1eaf850 
shouldn't this be add instead of update?
@jvillafanez
Add changelog entry
b0d1efb
@jvillafanez
Copy link
Member

jvillafanez commented Jun 15, 2022

Rebased and changelog added.

I don't think it will fix anything. The code is used in

core/lib/private/Files/Utils/Scanner.php

Lines 153 to 161 in 817f54f

$scanner->listen('\OC\Files\Cache\Scanner', 'removeFromCache', function ($path) use ($storage) {
$this->triggerPropagator($storage, $path);
});
$scanner->listen('\OC\Files\Cache\Scanner', 'updateCache', function ($path) use ($storage) {
$this->triggerPropagator($storage, $path);
});
$scanner->listen('\OC\Files\Cache\Scanner', 'addToCache', function ($path) use ($storage) {
$this->triggerPropagator($storage, $path);
});
and

core/lib/private/Files/Utils/Scanner.php

Lines 230 to 238 in 817f54f

$scanner->listen('\OC\Files\Cache\Scanner', 'removeFromCache', function ($path) use ($storage) {
$this->postProcessEntry($storage, $path);
});
$scanner->listen('\OC\Files\Cache\Scanner', 'updateCache', function ($path) use ($storage) {
$this->postProcessEntry($storage, $path);
});
$scanner->listen('\OC\Files\Cache\Scanner', 'addToCache', function ($path) use ($storage) {
$this->postProcessEntry($storage, $path);
});
, and the code path is the same with and without the PR.

I'm not sure if there is any 3rd-party app listening to those events, but it should be more consistent now.

@phil-davis phil-davis self-assigned this Jun 15, 2022
@phil-davis
Copy link
Contributor

phil-davis commented Jun 15, 2022

Assigned myself so that I notice this and merge it when CI passes.

@owncloud owncloud deleted a comment from update-docs bot Jun 15, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 3542266 into master Jun 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-vs-update branch June 15, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@phil-davis phil-davis phil-davis approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@phil-davis phil-davis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@butonic @phil-davis @jvillafanez
X Tutup