X Tutup
Skip to content

Fix encryption when the file is moved out of a share#39829

Merged
jvillafanez merged 2 commits intomasterfrom
encryption_moveout_share
Feb 28, 2022
Merged

Fix encryption when the file is moved out of a share#39829
jvillafanez merged 2 commits intomasterfrom
encryption_moveout_share

Conversation

@jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented Feb 24, 2022 •
edited by phil-davis
Loading

Description

Having encryption enabled, moving out a file out of a shared folder was breaking the encryption

Also see small fix in #39842

Related Issue

owncloud/encryption#321

Motivation and Context

How Has This Been Tested?

Manually tested based on the steps described in the linked issue
Checked with:

  • Shared folder in the root
  • Shared folder in a folder (not root)
  • Renamed shared folder for the user (Brian in the issue steps)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this Feb 24, 2022
@update-docs
Copy link

update-docs bot commented Feb 24, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez jvillafanez mentioned this pull request Feb 24, 2022
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

61.5% 61.5% Coverage
0.0% 0.0% Duplication

@jvillafanez jvillafanez merged commit fe8ada3 into master Feb 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the encryption_moveout_share branch February 28, 2022 12:23
@phil-davis phil-davis mentioned this pull request Mar 1, 2022
Closed
@jvillafanez jvillafanez mentioned this pull request Mar 1, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jvillafanez jvillafanez

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jvillafanez @AlexAndBear
X Tutup