Public-files endpoint won't stream multistatus#39797
Merged
DeepDiver1975 merged 4 commits intomasterfrom Feb 17, 2022
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Contributor
|
💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
Contributor
|
💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
Member
Author
|
@phil-davis is this a known issue? I've tried to reproduce the failing test manually, but it works. |
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
This is ready. |
DeepDiver1975
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The public-files endpoint won't stream the result, preventing a malformed XML to be sent in some scenarios where an error happens
Related Issue
#39707
Motivation and Context
A malformed XML could cause additional issues
How Has This Been Tested?
Manually checked with the steps described in the linked issue.
Screenshots (if appropriate):
Types of changes
Checklist: