[full-ci] Acceptance tests for deep moves and fix 39702#39703
Merged
phil-davis merged 3 commits intomasterfrom Jan 21, 2022
Merged
[full-ci] Acceptance tests for deep moves and fix 39702#39703phil-davis merged 3 commits intomasterfrom
phil-davis merged 3 commits intomasterfrom
Conversation
This was referenced Jan 20, 2022
Member
individual-it
left a comment
There was a problem hiding this comment.
this issue was first discovered using the windows explorer and I it only happened when moving a numeric file/folder to the root of the tree
so you maybe want to add those tests also
Contributor
Author
done in 3rd commit |
|
Kudos, SonarCloud Quality Gate passed! |
individual-it
approved these changes
Jan 21, 2022
jvillafanez
approved these changes
Jan 21, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Related Issue
fixes #39702
How Has This Been Tested?
CI
In the first commit: https://drone.owncloud.com/owncloud/core/34371/93/13
In the 3rd commit, locally without tghe fix, I get:
The fails happened when the target of the move was a path that starts with a non-zero number
For example, moving a file up to the root and calling it "1".
Or moving a file to a folder called "1".
Somehow the cases where the target path starts with a "0" did not fail.
CI passes with the 2nd commit, and 3rd commit.
Also, everything was OK with the "new" dav_version. Only "old" dav_version failed. That seems strange, but I guess there must be different ways that those make use of
sabre/davTypes of changes
Checklist: