Fix files:checksums:verify for a single file by phil-davis · Pull Request #39683 · owncloud/core

phil-davis · 2022-01-12T11:28:34Z

Description

files:checksums:verify fails if run against just a single file (specify -u someuser -p somefile.ext)

I added a unit test that does this, and it fails as follows:

/home/phil/git/owncloud/core/lib/composer/phpunit/phpunit/phpunit --configuration phpunit-autotest.xml --log-junit autotest-results-sqlite.xml ../apps/files/tests/Command/VerifyChecksumsTest.php 
PHPUnit 9.5.11 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.27
Configuration: phpunit-autotest.xml

......E.....                                                      12 / 12 (100%)

Time: 00:00.709, Memory: 28.00 MB

There was 1 error:

1) OCA\Files\Tests\Command\VerifyChecksumsTest::testSingleFileInGivenPathArgumentIsRepaired
Error: Call to undefined method OC\Files\Node\File::getDirectoryListing()

/home/phil/git/owncloud/core/apps/files/lib/Command/VerifyChecksums.php:214
/home/phil/git/owncloud/core/apps/files/lib/Command/VerifyChecksums.php:121
/home/phil/git/owncloud/core/lib/composer/symfony/console/Command/Command.php:255
/home/phil/git/owncloud/core/lib/composer/symfony/console/Tester/CommandTester.php:76
/home/phil/git/owncloud/core/apps/files/tests/Command/VerifyChecksumsTest.php:290

ERRORS!
Tests: 12, Assertions: 47, Errors: 1.
make: *** [Makefile:195: test-php-unit] Error 2

The test passes with the fixed code.

Related Issue

Fixes https://github.com/owncloud/enterprise/issues/4946

How Has This Been Tested?

Added a unit test that fails without the fix, and passes with the fix.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)