Fix getting the file owner for share recipients#39670
Merged
JammingBen merged 1 commit intorelease-10.9.1from Jan 11, 2022
Merged
Fix getting the file owner for share recipients#39670JammingBen merged 1 commit intorelease-10.9.1from
JammingBen merged 1 commit intorelease-10.9.1from
Conversation
JammingBen
force-pushed
the
issues/39662
branch
from
5b23448 to
35d97bf
Compare
|
Kudos, SonarCloud Quality Gate passed! |
11 tasks
phil-davis
approved these changes
Jan 10, 2022
Contributor
There was a problem hiding this comment.
See PR #39675 - that has 2 new scenarios that demonstrate this issue, and they pass with this code.
I can't just cherry-pick those in here, because they need various test code from master that is not in the release-10.9.1 branch. If we want, we could merge #39639 to release-10.9.1 to get all that test code into the release branch. But it might be best not to do that - we might accidentally cause some merge problem back to master...
When we merge back things from release-10.9.1 to master (however we do that in a controlled way), we can also apply the test scenarios to master.
This was referenced Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where a wrong file owner was retrieved when saving version authors. This scenario happened for share recipients if they had a file with the same name as the shared one.
Related Issue
Types of changes
Checklist: