Hide resend invitation mail - if user is guest#39602
Conversation
There was a problem hiding this comment.
Works for me in the webUI. The resend "envelope" icon is not shown for guest users. It is still shown for a new regular user.
Note: there is no backend "protection" of the endpoint. Sending to this with admin authentication:
http://172.17.0.1:8080/index.php/resend/invitation/someguest%40example.com
That will still send an "invitation"-style email to the guest, which has words that are not really correct for a guest.
But I guess that is OK. Someone has to have admin credentials and purposely do a "backend" request for that to happen. Random people cannot "just do it".
|
@phil-davis THX for hint, added backend protection |
|
Kudos, SonarCloud Quality Gate passed! |
|
@janackermann, @phil-davis since I do not have access to the enterprise repo I'll ask my question here:
Could you please explain why this is the case? With our customers we sometimes have got the issue that the original invitation mail is somehow lost or they deleted it by mistake. In such a case any admin could use the functionality "Resend invitation email". Now the only way to have sent an email to the new guest is deleting this guest user and to re-create any shares that were created for this user. AND this must be the original sharer(s) and not any admin. So we're losing a lot of functionality or am I wrong? Edit: Maybe the issue description is not clear. Does this mean guest users cannot resend invitation mails any further? Even if this is the case, what if a guest user is a group admin, shouldn't they be able to use this functionality? Edit2: guest users can be (sub)admins, see owncloud/guests#480 (comment) |
|
@janackermann please answer. I am not familiar with guests users and the invitation workflow. |
|
@janackermann, @pmaier1 What is the status here? Will guest users who are (group) admins lose functionality? |
This has been released with Server 10.9. Guest users will not lose functionality. This is only about the feature in user management to resend an invitation to users. The feature was designed for regular users which have an invite expiration time, not for guests. Guest invitations do not expire. The change here hides the "resend invite" feature for guest users therefore. |
|
Confirmed fixed in 10.10.0 RC2 |
6 participants
Description
Bugfix: Don't resend invitation mail if a user is guest
With this change the resend invitation mail action in the user management
UI for guest users has been removed, it is not appropriate for this type
of user.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: