X Tutup
Skip to content

Show explicit error message while moving a mount point into another m…#39584

Merged
jnweiger merged 3 commits intomasterfrom
issues/39550
May 4, 2022
Merged

Show explicit error message while moving a mount point into another m…#39584
jnweiger merged 3 commits intomasterfrom
issues/39550

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Dec 13, 2021

Enhancement: Show detailed error message if moving a mount into another fails

With this change, a detailed error message is shown when moving a mount point
into another mount point fails.
This is for example the case while moving a shared folder into a SFTP
external storage.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jvillafanez
Copy link
Member

Has it been tested with S3 as primary storage? I assume it works, but better confirm it.

@phil-davis
Copy link
Contributor

Note: I raised issue #39725 to add a few test scenarios that use the webdav_owncloud external storage. We already have a core test suite that has the environment all set up, so it should be "easy" to demonstrate some current core API behavior and then see that the various prohibited move attempts get a different/better response message with the code in this PR.

@phil-davis
Copy link
Contributor

@janackermann PR #39772 add API test scenarios relevant to this fix. It has been merged.
I have rebased this PR and adjusted the 2 test scenarios that now give the correctly-adjusted message - good.

But there are 2 other new scenarios in https://github.com/owncloud/core/blob/master/tests/acceptance/features/cliExternalStorage/filesExternalWebdavOwncloud.feature that give a 500 error. Look for the issue-39550 tag.

Please have a look at those. Can the 500 status error be fixed here in this PR?
(And adjust the test scenarios so that they have corrected test expectations)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 15, 2022
@phil-davis
Copy link
Contributor

Rebased - hopefully CI will still be happy.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis
Copy link
Contributor

@janackermann I rebased and this passes - is it fine to merge?

@owncloud owncloud deleted a comment from update-docs bot May 3, 2022
@jnweiger jnweiger merged commit e5a2c4a into master May 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/39550 branch May 4, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot move shared folder into an external storage

5 participants

X Tutup