X Tutup
Skip to content

[10.9.0] Change remote to federated in text strings#39578

Merged
JammingBen merged 1 commit intorelease-10.9.0from
change-remote-to-federated-in-text-strings
Dec 9, 2021
Merged

[10.9.0] Change remote to federated in text strings#39578
JammingBen merged 1 commit intorelease-10.9.0from
change-remote-to-federated-in-text-strings

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Dec 9, 2021

Description

Changes 2 more "remote share" to "federated share" in user-facing strings.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Dec 9, 2021
@phil-davis
Copy link
Contributor Author

phil-davis commented Dec 9, 2021

Note: If we merge this to release-10.9.0 then the strings will be changed in English and will not have translations in the release branch.

If we want translations in the release then we would have to also put this in master and then add the translations in Transifex, get them back to master then cherry-pick them to the release branch.

@phil-davis phil-davis mentioned this pull request Dec 9, 2021
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 362e742 into release-10.9.0 Dec 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the change-remote-to-federated-in-text-strings branch December 9, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@IljaN IljaN Awaiting requested review from IljaN

@jnweiger jnweiger Awaiting requested review from jnweiger

1 more reviewer

@JammingBen JammingBen JammingBen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phil-davis phil-davis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @JammingBen
X Tutup