X Tutup
Skip to content

Bump google/apiclient from 2.11.0 to 2.12.1 in /apps/files_external/3rdparty#39567

Merged
phil-davis merged 3 commits intomasterfrom
dependabot/composer/apps/files_external/3rdparty/google/apiclient-2.12.1
Feb 10, 2022
Merged

Bump google/apiclient from 2.11.0 to 2.12.1 in /apps/files_external/3rdparty#39567
phil-davis merged 3 commits intomasterfrom
dependabot/composer/apps/files_external/3rdparty/google/apiclient-2.12.1

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 6, 2021 •
edited
Loading

Bumps google/apiclient from 2.11.0 to 2.12.1.

Release notes

Sourced from google/apiclient's releases.

v2.12.1

Fixes

  • fix: remove error block of code (#2163)

v2.12.0

Features

  • allow credentials object (#2153)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies php Pull requests that update Php code labels Dec 6, 2021
@ownclouders
Copy link
Contributor

ownclouders commented Dec 6, 2021

💥 Acceptance tests pipeline apiAuthWebDav-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33938/49/1

@dependabot dependabot bot force-pushed the dependabot/composer/apps/files_external/3rdparty/google/apiclient-2.12.1 branch from 61441b6 to 087df36 Compare January 25, 2022 13:04
@phil-davis phil-davis self-assigned this Jan 25, 2022
@phil-davis phil-davis self-requested a review January 25, 2022 13:05
@phil-davis
Copy link
Contributor

phil-davis commented Jan 25, 2022 •
edited
Loading

Needs:

  • commit the actual dependent code
  • changelog

@phil-davis
Copy link
Contributor

phil-davis commented Feb 10, 2022

@dependabot rebase

@dependabot
Bump google/apiclient in /apps/files_external/3rdparty
7e5ad26 
Bumps [google/apiclient](https://github.com/googleapis/google-api-php-client) from 2.11.0 to 2.12.1.
- [Release notes](https://github.com/googleapis/google-api-php-client/releases)
- [Commits](googleapis/google-api-php-client@v2.11.0...v2.12.1)

---
updated-dependencies:
- dependency-name: google/apiclient
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/composer/apps/files_external/3rdparty/google/apiclient-2.12.1 branch from 087df36 to 7e5ad26 Compare February 10, 2022 04:44
@owncloud owncloud deleted a comment from update-docs bot Feb 10, 2022
@phil-davis
Copy link
Contributor

phil-davis commented Feb 10, 2022 •
edited
Loading

I did:

$ cd apps/files_external/3rdparty/
$ composer install

And it changed more than 5,000 files, added 325,505 lines of code. Normally the google/apiclient version changes do touch a lot of their code, but this seems unusually high.

apps/files_external/3rdparty/google/apiclient-services has had a huge amount of lines added.

$ git diff --name-status master shows that most of the changes are modifed files.

$ git diff --name-status master | grep "^M" | wc -l
10230
$ git diff --name-status master | grep "^A" | wc -l
314
$ git diff --name-status master | grep "^D" | wc -l
0

A few changes that I sampled have a bunch of new code, and lines like:

+// Adding a class alias for backwards compatibility with the previous class name.
+class_alias(MatchedUrl::class, 'Google_Service_HangoutsChat_MatchedUrl');

So it looks like they have done some major refactoring and lots of code has been added to keep backward-compatibility. If CI passes, then I guess we have to have all this.

$ du -hs apps/files_external/
88M	apps/files_external/
$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
$ du -hs apps/files_external/
85M	apps/files_external/
$ du -hs apps/files_external/3rdparty/google
72M	apps/files_external/3rdparty/google

This added about 3MB size.

I am surprised at how much space apps/files_external/3rdparty/google already takes - 72MB. The owncloud-complete tarball has 262.3MB of files in it, and this "3rdparty" stuff takes a significant part of that space.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit cbdde8a into master Feb 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the dependabot/composer/apps/files_external/3rdparty/google/apiclient-2.12.1 branch February 10, 2022 06:35
This was referenced Feb 10, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@phil-davis phil-davis

Labels

dependencies php Pull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ownclouders @phil-davis
X Tutup