X Tutup
Skip to content

Fix x-icon position in select2 search fields#39563

Merged
JammingBen merged 1 commit intorelease-10.9.0from
issues/39559
Dec 6, 2021
Merged

Fix x-icon position in select2 search fields#39563
JammingBen merged 1 commit intorelease-10.9.0from
issues/39559

Conversation

@JammingBen
Copy link
Contributor

Description

This was a regression introduced by #39146. The original padding has been restored.

Related Issue

Screenshots (if appropriate):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - works in Admin General Settings and Tags, so it should work wherever else it is used.

@JammingBen JammingBen merged commit 6040c59 into release-10.9.0 Dec 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/39559 branch December 6, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove button overlays item name in multi-select boxes

2 participants

X Tutup