Check if groupname is empty or already exists while creating user#39532
Merged
micbar merged 1 commit intorelease-10.9.0from Nov 25, 2021
Merged
Check if groupname is empty or already exists while creating user#39532micbar merged 1 commit intorelease-10.9.0from
micbar merged 1 commit intorelease-10.9.0from
Conversation
phil-davis
approved these changes
Nov 25, 2021
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
works for me. I can't get "duplicate" groups. I can't add a group that is just spaces.
Note: I can add a group whose name starts with a space, like " aaa". But that is an existing long-time feature.
AlexAndBear
force-pushed
the
enterprise/issues/4890
branch
from
66c2d46 to
d1311c8
Compare
Author
This is unacceptable, thx for hint, fixed. |
|
SonarCloud Quality Gate failed. |
Author
|
@micbar unfortunately we don't have a spec file for that, can you merge this? |
JammingBen
approved these changes
Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the admin could create groups with empty name or multiple
times with the same name.
This has been fixed with this change.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: