Fix: Selecting the "show password" icon in password input field does not show the password#39528
Merged
AlexAndBear merged 1 commit intorelease-10.9.0from Nov 23, 2021
Merged
Fix: Selecting the "show password" icon in password input field does not show the password#39528AlexAndBear merged 1 commit intorelease-10.9.0from
AlexAndBear merged 1 commit intorelease-10.9.0from
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
phil-davis
reviewed
Nov 23, 2021
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
works - tested by:
- set
'installed' => false,inconfig/config.php - browse to the URL of the installation
- the installation page is displayed
- enter text in the 2 password fields
- toggle the "show password" icon in each
- the password(s) is displayed
AlexAndBear
force-pushed
the
issues/39527
branch
from
3798dae to
0e578a6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
JammingBen
approved these changes
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the installation, the user should be able to click the eye icon in the admin
user and database password field to see the password, this recently
stopped to work and has been fixed with this change.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: