SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

4.8% Coverage
0.0% Duplication

Well .... That file is not unit testable ... 🤷

Then @micbar has the mighty power the merge regardless of the SonarCloud result :)

The issue just popped up on another instance (also AD+shib ...) - patch was applied and fixed the issue.

Next questions:

• will this happen now on all AD instances
• release with 10.9

This instance has no shib, only AD

could that have performance implications?
We could test with cdperf.

could that have performance implications?

tearing down the fs is a fairly simple operation ... I can hardly imagine any impact.
I would still be great to find a way to not initialize the fs with the wrong user in the first place ;-)

I (or anybody else) could have a look into this if time permits ....

Stacktrace without shib ownCloud 10.8.04

User can't access public-links when logged in.
{"reqId":"YZy4L-8qBKL8-4bdX5Ee9AAAAAQ","level":0,"time":"2021-11-23T10:45:19+01:00","remoteAddr":"10.******","user":"--","app":"webdav","method":"PROPFIND","url":"\/public.php\/webdav\/","message":"Exception: HTTP\/1.1 404 Not Found: {\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\NotFound\",\"Message\":\"\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/ServerFactory.php(144): {closure}(*** sensitive parameters replaced ***)\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/WildcardEmitterTrait.php(89): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\ServerFactory->OCA\\\\DAV\\\\Connector\\\\Sabre\\\\{closure}(*** sensitive parameters replaced ***)\\n#2 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(456): Sabre\\\\DAV\\\\Server->emit()\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(253): Sabre\\\\DAV\\\\Server->invokeMethod()\\n#4 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(321): Sabre\\\\DAV\\\\Server->start()\\n#5 \\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/publicwebdav.php(105): Sabre\\\\DAV\\\\Server->exec()\\n#6 \\\/var\\\/www\\\/owncloud\\\/public.php(75): require_once('\\\/var\\\/www\\\/ownclo...')\\n#7 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/publicwebdav.php\",\"Line\":85}"}

@IljaN please add these log lines to see if the fs is the issue:
https://github.com/owncloud/core/pull/39518/files#diff-881e8db59b87914234308a17ebb28970eca4e062bb15c3808456772738590b70R96-R100

THX

@DeepDiver1975 None of the log messages from this PR were fired after applying the Patch. Non the less the Patch fixes this. We tried to remove it again on a test-instance and logged-in pub shares were broken.

@DeepDiver1975 None of the log messages from this PR were fired after applying the Patch. Non the less the Patch fixes this. We tried to remove it again on a test-instance and logged-in pub shares were broken.

especially in the scenario where pub shares are broken I'd expect the log message.
Please only apply https://github.com/owncloud/core/pull/39518/files#diff-881e8db59b87914234308a17ebb28970eca4e062bb15c3808456772738590b70R96-R100 to get the log message.

Do not apply the rest of the patch.

@DeepDiver1975 this is not in the release-10.9.0 branch.
Does it need to be released "soon" in 10.9.0?

Does it need to be released "soon" in 10.9.0?

no - thx

Tested public links without shib.
Looks good in 10.10.0 RC2