X Tutup
Skip to content

Change way how to show/hide tag edit actions#39517

Merged
AlexAndBear merged 1 commit intorelease-10.9.0from
issues/39515
Nov 22, 2021
Merged

Change way how to show/hide tag edit actions#39517
AlexAndBear merged 1 commit intorelease-10.9.0from
issues/39515

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Nov 22, 2021 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiProxySmoke-8-5-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33793/174/1

@AlexAndBear AlexAndBear changed the base branch from master to release-10.9.0 November 22, 2021 13:44
@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline webUIFfSmoke-3-1-firefox-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33794/161/1

@AlexAndBear
Copy link
Author

AlexAndBear commented Nov 22, 2021

Ok, this is not the approach we should choose...
The hidden class will not be deleted from some items, even if it should.

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline webUIPersonalSetting-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33795/134/1

@owncloud owncloud deleted a comment from CLAassistant Nov 22, 2021
@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiWebdavOperations-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33796/94/1

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiShareManagementToShares-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33796/64/1

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiComments-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33796/51/1

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiCapabilities-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33796/50/1

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiWebdavLocks2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33796/89/1

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiShareReshareToShares3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33796/78/1

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiSharingNotificationsToShares-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33796/101/1

@ownclouders
Copy link
Contributor

ownclouders commented Nov 22, 2021

💥 Acceptance tests pipeline apiAuth-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33796/47/1

@owncloud owncloud deleted a comment from ownclouders Nov 22, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 22, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 22, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 22, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 22, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 22, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 22, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 22, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear changed the title .hidden class should always overwrite applied display attribute Change way how to show/hide tag edit actions Nov 22, 2021
phil-davis
phil-davis approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@AlexAndBear AlexAndBear merged commit 5d68524 into release-10.9.0 Nov 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/39515 branch November 22, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@hurradieweltgehtunter hurradieweltgehtunter Awaiting requested review from hurradieweltgehtunter

+1 more reviewer

@JammingBen JammingBen JammingBen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.9-regression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Renaming a tag shows another pencil icon, a second edit box opens

4 participants

@AlexAndBear @ownclouders @phil-davis @JammingBen
X Tutup