X Tutup
Skip to content

Fix search inside a shared external storage#39500

Merged
JammingBen merged 2 commits intomasterfrom
search_local_share
Nov 18, 2021
Merged

Fix search inside a shared external storage#39500
JammingBen merged 2 commits intomasterfrom
search_local_share

Conversation

@jvillafanez
Copy link
Member

Description

Searching a file inside a shared external storage didn't return any result even though there was files inside that should be returned. This PR fixes the issue.

Related Issue

https://github.com/owncloud/enterprise/issues/4677

Motivation and Context

How Has This Been Tested?

  1. Create an external storage (Local storage) only available to the admin. Ensure the mount point can be shared
  2. Upload some files in "A/B/C/" (inside the external storage -> "Local/A/B/C/searchtest.txt")
  3. Share the whole mount point with user1
  4. As user1, access to "Local/A/B"
  5. Search "test"

The "searchtest.txt" file inside the shared folder should appear in the results

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a changelog would be nice though

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 888f8b2 into master Nov 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the search_local_share branch November 18, 2021 13:23
@jnweiger
Copy link
Contributor

Confirmed fixed in 10.9.0 RC1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup