X Tutup
Skip to content

Bump sabre dependencies#39453

Merged
JammingBen merged 3 commits intomasterfrom
sabre-http-5.1.2
Nov 4, 2021
Merged

Bump sabre dependencies#39453
JammingBen merged 3 commits intomasterfrom
sabre-http-5.1.2

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Nov 4, 2021 •
edited
Loading

Description

  1. A release of sabre/http
$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 2 updates, 0 removals
  - Upgrading nikic/php-parser (v4.13.0 => v4.13.1)
  - Upgrading sabre/http (5.1.1 => 5.1.2)
Writing lock file

https://github.com/sabre-io/http/releases/tag/5.1.2

  1. Then I made releases of some other sabre dependencies
$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 3 updates, 0 removals
  - Upgrading sabre/event (5.1.2 => 5.1.3)
  - Upgrading sabre/vobject (4.3.5 => 4.3.6)
  - Upgrading sabre/xml (2.2.3 => 2.2.4)
Writing lock file
  1. I missed bumping a VERSION constant in the releases, so I had to make another patch release of each:
$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
  - Upgrading sabre/event (5.1.3 => 5.1.4)
  - Upgrading sabre/http (5.1.2 => 5.1.3)
  - Upgrading sabre/vobject (4.3.6 => 4.3.7)
  - Upgrading sabre/xml (2.2.4 => 2.2.5)
Writing lock file

Note: nikic/php-parser is a dev tool, so no changelog needed for that.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis added dependencies php Pull requests that update Php code labels Nov 4, 2021
@phil-davis phil-davis self-assigned this Nov 4, 2021
JammingBen
JammingBen suggested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, LGTM beside that.

@phil-davis phil-davis requested a review from JammingBen November 4, 2021 07:20
@phil-davis phil-davis changed the title Bump sabre/http (5.1.1 => 5.1.2) Bump sabre dependencies Nov 4, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JammingBen JammingBen merged commit 032a23e into master Nov 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the sabre-http-5.1.2 branch November 4, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@IljaN IljaN Awaiting requested review from IljaN

1 more reviewer

@JammingBen JammingBen JammingBen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phil-davis phil-davis

Labels

dependencies php Pull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @JammingBen
X Tutup