Add missing 'remoteshare.accepted' event parameters#39449
Merged
AlexAndBear merged 1 commit intomasterfrom Nov 2, 2021
Merged
Conversation
phil-davis
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
jvillafanez
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix adds missing parameters to the
remoteshare.acceptedevent when triggered via controller:shareId,fileId,shareRecipient.The bugfix is a complement to #38880. It will be needed for the next release of the activity app which includes: owncloud/activity#972
Because the "logic" itself already exists (and to avoid code duplication) the relevant parts have been encapsulated into own methods.
Types of changes
Checklist: