X Tutup
Skip to content

[tests-only] Bump karma from 4.4.1 to 6.3.4#39385

Merged
JammingBen merged 1 commit intomasterfrom
bump-karma-6.3.4-2
Oct 20, 2021
Merged

[tests-only] Bump karma from 4.4.1 to 6.3.4#39385
JammingBen merged 1 commit intomasterfrom
bump-karma-6.3.4-2

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 20, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@JammingBen JammingBen mentioned this pull request Oct 20, 2021
Closed
11 tasks
phil-davis
phil-davis approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes it should be OK.
If we are going to bump all the JS dependencies then we should do a fair bit of exploratory testing of the webUI at the end - to see if there are any noticeable visual differences, or things that the acceptance tests did not find.

@JammingBen
Copy link
Contributor Author

JammingBen commented Oct 20, 2021

If we are going to bump all the JS dependencies then we should do a fair bit of exploratory testing of the webUI at the end - to see if there are any noticeable visual differences, or things that the acceptance tests did not find.

Seems like a good idea. I have two more test-related dependencies on my to-do list (sinon and karma-jasmine). Afterwards I'll go through the other JS-PRs (assuming nothing else pops up).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JammingBen JammingBen merged commit f5b1620 into master Oct 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-karma-6.3.4-2 branch October 20, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

No one assigned

Labels

dependencies javascript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JammingBen @phil-davis
X Tutup