X Tutup
Skip to content

fix: no sensitive data shall be displayed on the exception page - eve…#39334

Merged
DeepDiver1975 merged 1 commit intomasterfrom
fix/no-sensetive-data-in-debug-exception-page
Oct 8, 2021
Merged

fix: no sensitive data shall be displayed on the exception page - eve…#39334
DeepDiver1975 merged 1 commit intomasterfrom
fix/no-sensetive-data-in-debug-exception-page

Conversation

@DeepDiver1975
Copy link
Member

…n in debug mode

Description

Related Issue

fixes https://github.com/owncloud/enterprise/issues/4783

How Has This Been Tested?

  • set debug => true in config.php
  • add a throw new Exception() in LoginController::tryLogin()
  • login
  • see the exception page
  • user name and password are not displayed in the stack trace

Screenshots (if appropriate):

Screenshot from 2021-10-08 10-34-14

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs

This comment has been minimized.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/no-sensetive-data-in-debug-exception-page branch from 0db1405 to 715165f Compare October 8, 2021 08:53
@DeepDiver1975 DeepDiver1975 changed the title fix: no sensetive data shall be displayed on the exception page - eve… fix: no sensitive data shall be displayed on the exception page - eve… Oct 8, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

Copy link

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeepDiver1975 DeepDiver1975 merged commit ec74221 into master Oct 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/no-sensetive-data-in-debug-exception-page branch October 8, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup