@phil-davis should we add acceptance tests for #20722 ?

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32824/145/1

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32825/145/1

Note: there is another scenario, which is a different existing feature:

• abc.txt and def.txt in the root folder
• favorite abc.txt
• on the Favorites page, try to rename abc.txt to def.txt
• it lets you try, but then a notification is displayed "The name "def.txt" is already used in the folder "/". Please choose a different name."

It would be nice if the on-the-fly rename code in the JavaScript could "understand" that the proposed name is already used. But that would require more real-time code that checks with the server on every character as it is typed, or when starting the "Rename" input, the JavaScript would have to get a list of all the files in the foldder of that item, so that it could check as the user types. Maybe not feasible.

Rebased to get fresh CI.

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32848/145/1

@janackermann I sorted out the shareByPublicLink test scenario that originally had a wrong Then step that actually did not check the right thing, and did not fail. But the scenario fails now because when I rename a resource on the "Shared by link" page, the hover text for the actual location of the resource does not get updated. See the screen-shot where I renamed "test" to "wwwwww" but the hover-text was still "ttt/test" (that folder is a sub-folder of folder "ttt")

There is the same problem on the "Shared with others" page.

If you can sort out the hover-text being updated (data-original-title) on rename, then the test scenario should pass.

The "Favorites" page does not seem to have any hover-text to give the user a clue where the resource really is. When I have 2 files with the same name on the Favorites page, I don't know how I can know which file is from which folder. If we can have some similar way for the user to know which resource is from where, then we can make test scenarios.

@phil-davis Thx, will take care

@phil-davis

If we can have some similar way for the user to know which resource is from where, then we can make test scenarios.

this has been introduced just know, do you want to adjust the tests?

I will come banck when CI is done, and look what happens and then see what other tests can be added.

@phil-davis friendly ping =)

https://drone.owncloud.com/owncloud/core/32907/31/8

+ phpdbg -d memory_limit=6G -rr ../lib/composer/bin/phpunit --configuration phpunit-autotest-external.xml --coverage-clover output/coverage/autotest-external-clover-sqlite-sftp.xml ../apps/files_external/tests/Storage/SftpTest.php
[Welcome to phpdbg, the interactive PHP debugger, v7.4.23]
To get help using phpdbg type "help" and press enter
[Please report bugs to <http://bugs.php.net/report.php>]
PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

Runtime:       PHPDBG 7.4.23
Configuration: phpunit-autotest-external.xml

.................................E............................... 65 / 92 ( 70%)
...........................                                       92 / 92 (100%)

Time: 00:31.609, Memory: 80.63 MB

There was 1 error:

1) OCA\Files_External\Tests\Storage\SftpTest::testMove with data set #7 ('/single ' quote.txt', '/tar'get.txt')
fwrite() expects parameter 1 to be resource, bool given

/drone/src/lib/private/Files/Storage/Common.php:207
/drone/src/tests/lib/Files/Storage/Storage.php:193
/drone/src/tests/lib/Files/Storage/Storage.php:226

ERRORS!
Tests: 92, Assertions: 369, Errors: 1.

That is a strange unit test fail - nothing to do with this PR. I will restart CI.

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

81.0% Coverage
0.0% Duplication