X Tutup
Skip to content

Fix file version names for share recipients#39314

Merged
JammingBen merged 2 commits intomasterfrom
issues/36228
Oct 1, 2021
Merged

Fix file version names for share recipients#39314
JammingBen merged 2 commits intomasterfrom
issues/36228

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 1, 2021

Description

With this fix, file version names now match with the actual file name for share recipients. Before, the name has been the timestamp of the version file.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 88b27f3 into master Oct 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/36228 branch October 1, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Versions downloaded of shared files are named with a number instead of the filename

4 participants

X Tutup