X Tutup
Skip to content

move template instead of clone to prevent bugs#39307

Merged
AlexAndBear merged 1 commit intomasterfrom
grouplist-do-not-use-clone
Sep 30, 2021
Merged

move template instead of clone to prevent bugs#39307
AlexAndBear merged 1 commit intomasterfrom
grouplist-do-not-use-clone

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Sep 29, 2021

Description

Cloning the previous li item have many downsides, for example:
The admin group does not have a remove button, creating the first group will not have it as well, but it should!
Better use a template instead of cloning.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear marked this pull request as ready for review September 29, 2021 14:09
@owncloud owncloud deleted a comment from update-docs bot Sep 29, 2021
@AlexAndBear AlexAndBear force-pushed the grouplist-do-not-use-clone branch from 99277f3 to 647581d Compare September 30, 2021 06:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit b64518a into master Sep 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the grouplist-do-not-use-clone branch September 30, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup