Sanitize data that gets sent to server on user create via webUI#39306
Sanitize data that gets sent to server on user create via webUI#39306
Conversation
AlexAndBear
force-pushed
the
issues/32619
branch
from
b65b492 to
81cefbf
Compare
AlexAndBear
force-pushed
the
issues/32619
branch
3 times, most recently
from
ccb4b72 to
9f366a6
Compare
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Test by:
- uncheck "Set password for new users"
- enter username "t123" and email "test" (thinking it is the password field)
- click Create
- see the message about "invalid email address"
- realize your error, now check "Set password for new users"
- enter "test" in the password field
- click Create
On master I get the message again about "invalid email address"
On this branch the user is created and has the initial password "test".
Works
phil-davis
changed the title
phil-davis
changed the title
|
IMO this is a bit of an edge case. No need to add an automated test scenario for this sequence. (If we have a scenario for every different possible order of clicking settings on/off and entering data in different orders, then the test matrix will explode and we will be the cause of global warming) |
jvillafanez
left a comment
jvillafanez
left a comment
There was a problem hiding this comment.
Just a couple of minor things, but overall looks good
AlexAndBear
force-pushed
the
issues/32619
branch
from
6be80e2 to
5c3d19f
Compare
|
Note, added a slightly UI improvement, + add group has now cursor:pointer |
|
SonarCloud Quality Gate failed. |
|
Before the recent commit we had 0 coverage Sonar Cloud passed, now he have 0 again and it fails? |
|
@micbar can you merge please ? |
|
@micbar ping - this is ready for merge. It just needs override of the coverage. |
4 participants
Description
Bugfix: Sanitize data send to the server while creating users via webUI
Before this change toggle between 'Set password for new users' option,
may preserve and send unwanted password or email information.
This has been fixed, the webUI will not send email data to the server
if the option 'Set password for new users' is active,
vice versa password won't be sent if the option is disabled.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: