X Tutup
Skip to content

Hide the 'Remove Password' button on public links#39302

Merged
JammingBen merged 1 commit intomasterfrom
issues/35684
Sep 29, 2021
Merged

Hide the 'Remove Password' button on public links#39302
JammingBen merged 1 commit intomasterfrom
issues/35684

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Sep 28, 2021

Description

This change hides the "Remove Password" button when editing a public link if a password in mandatory.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

47.6% 47.6% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit a68d373 into master Sep 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/35684 branch September 29, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Share by link] Remove password button should not be shown when the password is enforced

2 participants

@JammingBen @jvillafanez
X Tutup