Merged
Conversation
phil-davis
reviewed
Sep 28, 2021
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
WFM. Note: the old versions seem to already be there. They were being saved, just not displayed. I uploaded a file called "0" a few times using master code. No versions were displayed. I switched to this branch and uploaded "0" again. I got all the versions displayed.
You could just add a unit test case for calling getVersions() with $filename "0".
phil-davis
approved these changes
Sep 28, 2021
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where files named "0" were missing their versions in the WebUI.
Related Issue
0does not have versions #36000Types of changes
Checklist: