Use buttons and icons for file list actions without text in mobile view#39233
Merged
AlexAndBear merged 1 commit intomasterfrom Sep 15, 2021
Merged
Use buttons and icons for file list actions without text in mobile view#39233AlexAndBear merged 1 commit intomasterfrom
AlexAndBear merged 1 commit intomasterfrom
Conversation
AlexAndBear
force-pushed
the
file-list-mobile-view-header-use-icons
branch
from
fa37bbd to
d5d5bb7
Compare
AlexAndBear
changed the title
Author
|
@pmaier1 agree? |
Contributor
|
As a separate thing, the "..." dropdown also shows each action with icon and text: Should we remove the text from those? |
Author
|
@phil-davis we should just shrink items, which takes too much space and conflicts with other elements. Moreover the ... menu should be full width in mobile view, from my POV Note: I am taking care of the restore text in deleted files in another PR |
|
Kudos, SonarCloud Quality Gate passed!
|
JammingBen
approved these changes
Sep 15, 2021
delete-merged-branch
bot
deleted the
file-list-mobile-view-header-use-icons
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhancement: Use icons + buttons instead of text for file actions in mobile view
Before this PR, as files were selected in the files list, actions was shown with
icon and text, for example: 'Download' and 'Delete'.
This uses much space and UI glitches are possible due to limited screen size.
With this PR we now show buttons with the associated icons without any text.
Screenshots (if appropriate):
Files - Before
Files - After
Deleted files - Before
Deleted files - After
Types of changes
Checklist: