X Tutup
Skip to content

Hide accept / decline text on mobile#39224

Merged
AlexAndBear merged 2 commits intomasterfrom
shared-with-you-mobile-ui-enhancement
Sep 13, 2021
Merged

Hide accept / decline text on mobile#39224
AlexAndBear merged 2 commits intomasterfrom
shared-with-you-mobile-ui-enhancement

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Sep 13, 2021

Description

Enhancement: Hide accept and decline share text on mobile view

Before this PR within the "Shared with you" files list, a text for accept
and decline was shown next to the associated icon.
These texts were using excessive space in the mobile view and might
leaving the "State" column not completely visible.
This has been fixed through hiding those not necessary texts with this PR.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Before

image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Sep 13, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear
Copy link
Author

AlexAndBear commented Sep 13, 2021

@pmaier1 agree?
I also wonder if we should have a text for an accepted / auto-accepted share in the status column?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear marked this pull request as ready for review September 13, 2021 14:00
@AlexAndBear AlexAndBear merged commit 71ac958 into master Sep 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the shared-with-you-mobile-ui-enhancement branch September 13, 2021 14:00
@phil-davis
Copy link
Contributor

@janackermann can you fill in some more information in the top post? Is there an issue to link to that describes why/what was required? Should there be a changelog entry for this?

@AlexAndBear
Copy link
Author

@phil-davis oops, will do ;)

phil-davis added a commit that referenced this pull request Sep 14, 2021
…ancement-changelog

[docs-only] Add changelog item for #39224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup