Set files_list to empty array if we don't have any selected files#39198
Merged
JammingBen merged 2 commits intomasterfrom Sep 9, 2021
Merged
Set files_list to empty array if we don't have any selected files#39198JammingBen merged 2 commits intomasterfrom
JammingBen merged 2 commits intomasterfrom
Conversation
Contributor
|
💥 Acceptance tests pipeline webUISharingPublic1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
AlexAndBear
force-pushed
the
issues/39187
branch
from
942c61d to
99380fd
Compare
jvillafanez
approved these changes
Sep 9, 2021
phil-davis
approved these changes
Sep 9, 2021
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
works - I tried:
- download all files/folders -
download.zipcomes - download just 2 files/folders -
download.zipcomes - download just 1 file - just the file downloads
- download just 1 folder -
folderName.zipcomes
Author
|
@phil-davis maybe we can add some acceptance tests later on? |
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
Issue #39199 |
11 tasks
Contributor
|
confirmed fixed in 10.9.0-beta1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: Set file name to download.zip while downloading the whole user directory
Before this PR, selecting all files and folders in the webUI and clicking the
download button, resulted in a file downloaded with the name ".zip".
With this PR the file name is now "download.zip".
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: