X Tutup
Skip to content

Display clickable links in upgrade process #39184

Merged
AlexAndBear merged 1 commit intomasterfrom
issues/39178
Sep 16, 2021
Merged

Display clickable links in upgrade process #39184
AlexAndBear merged 1 commit intomasterfrom
issues/39178

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Sep 8, 2021

Description

Enhancement: Display clickable links during web UI upgrade process

Before this PR, error messages can contain links that have not been clickable.
With this PR, links are clickable and open them in a new tab.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):#

Before

image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot Sep 8, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review September 8, 2021 09:53
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiCapabilities-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/49/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProvisioning-v1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/53/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareCreateSpecialToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/59/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFavorites-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/51/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareCreateSpecialToShares2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/60/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareCreateSpecialToShares1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/58/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/166/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/148/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingIntUsers2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/143/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-7-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/171/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIProxySmoke-3-3-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/164/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingExt1-latest-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/154/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIFfSmoke-3-3-firefox-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/161/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiOnSqlite-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/173/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIProxySmoke-3-2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/163/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-6-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/170/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingPublic1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32216/144/1

@jvillafanez
Copy link
Member

There are other message sources around

updateEventSource.listen('success', function(message) {
, I'm not sure if we also want to handle those the same way or not.

updateEventSource.listen('notice', function(message) {
  message = this.parseMessage(message);
  self.setPermanentMessage(message);
  hasWarnings = true;
});

that's a bit more clear if we want to parse only that message.

@AlexAndBear
Copy link
Author

@jvillafanez I don't think we only want to parse this particular message type. For me, it makes sense to take care for all of them.

@AlexAndBear
Copy link
Author

Note: I updated the missing space char for 'Reperaturwarnung' in transifex

@jvillafanez
Copy link
Member

@jvillafanez I don't think we only want to parse this particular message type. For me, it makes sense to take care for all of them.

The setMessage and setErrorMessage should be treated the same way then

@AlexAndBear
Copy link
Author

@jvillafanez done

@jvillafanez
Copy link
Member

It seems it needs some adjustments in the tests, but the code looks fine to me.

@AlexAndBear
Copy link
Author

@jvillafanez
yes, this is related to #39246 (review)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit b3d4fe0 into master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QA] link in update message is not clickable

4 participants

X Tutup