Update appinfo cache only if the app version is newer#39108
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Member
Author
|
There are no clear steps to reproduce the original problem, so it's difficult to foresee if this PR will fix the issue. |
JammingBen
previously requested changes
Aug 25, 2021
jvillafanez
force-pushed
the
fix_app_cache
branch
from
623c2b7 to
ea07549
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
cannot reproduce the issue now, but the changes look indeed very promising. Thanks for the hard digging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cache app info for the appid only if the version is newer.
Related Issue
#38549
Motivation and Context
If there are multiple versions of the same app in different locations, we're expected to use the one with the latest version.
Note that the problem happens having a local cache active.
How Has This Been Tested?
occ market:upgrade <app>There is no problem with the upgrade. The installed version in the DB is the latest one (downloaded from the market). Reloading the page doesn't trigger the "update needed" page.
Screenshots (if appropriate):
Types of changes
Checklist: