X Tutup
Skip to content

Change wording for enable file locking checkbox#39106

Merged
pmaier1 merged 1 commit intomasterfrom
file_locking_label
Aug 11, 2021
Merged

Change wording for enable file locking checkbox#39106
pmaier1 merged 1 commit intomasterfrom
file_locking_label

Conversation

@pmaier1
Copy link
Contributor

@pmaier1 pmaier1 commented Aug 11, 2021

Current wording is confusing because the checkbox is only controlling the feature on the web UI. It will not affect the API and consequently not the other clients.

@pmaier1 pmaier1 self-assigned this Aug 11, 2021
@update-docs
Copy link

update-docs bot commented Aug 11, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@phil-davis
Copy link
Contributor

phil-davis commented Aug 11, 2021

@pmaier1 what is the rule for changelogs in this situation?
Only some text on the UI has changed. There is not "real behavior" change.

@ownclouders
Copy link
Contributor

ownclouders commented Aug 11, 2021

💥 Acceptance tests pipeline webUIAddUsers-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31854/130/1

@pmaier1
Copy link
Contributor Author

pmaier1 commented Aug 11, 2021 •
edited
Loading

@pmaier1 what is the rule for changelogs in this situation?

I wouldn't see it as mandatory. If you'd like to add one for me, I'd be happy as well :)

Any change should be reflected in the changelog. Can you add one for me, please?

@phil-davis
Copy link
Contributor

phil-davis commented Aug 11, 2021

Can you add one for me, please?

Done

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pmaier1 pmaier1 merged commit 3d114b6 into master Aug 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the file_locking_label branch August 11, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@ChrisEdS ChrisEdS Awaiting requested review from ChrisEdS

+1 more reviewer

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pmaier1 pmaier1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmaier1 @phil-davis @ownclouders @AlexAndBear
X Tutup