X Tutup
Skip to content

Clarify days parameter of the occ dav:cleanup-chunks command#39090

Merged
phil-davis merged 1 commit intomasterfrom
clarify-dav-cleanup-chunks
Aug 3, 2021
Merged

Clarify days parameter of the occ dav:cleanup-chunks command#39090
phil-davis merged 1 commit intomasterfrom
clarify-dav-cleanup-chunks

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 3, 2021

Description

The days parameter of the occ dav:cleanup-chunks command is actually the minimum number of days old for cleaning up chunks. This was not 100% clear from the command help. The text and parameter name have been adjusted to say it is the minimum days.

I noticed when thinking about #39068 (comment) and how to test this command.

$ php occ dav:cleanup-chunks --help
Description:
  Cleanup outdated chunks

Usage:
  dav:cleanup-chunks [<minimum-age-in-days>]

Arguments:
  minimum-age-in-days   minimum age of uploads to cleanup (in days - minimum 2 days - maximum 100) [default: 2]

Options:
  -h, --help            Display this help message
  -q, --quiet           Do not output any message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
      --no-warnings     Skip global warnings, show command output only
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

How Has This Been Tested?

CI and local command use.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised: I checked in docs and the command is described OK there
  • Changelog item, see TEMPLATE

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, also matches with the official docs.

The parameter needs to be adjusted in the unit tests though.

@phil-davis phil-davis force-pushed the clarify-dav-cleanup-chunks branch from bce7ea5 to 42ffc34 Compare August 3, 2021 07:40
@phil-davis phil-davis requested a review from JammingBen August 3, 2021 07:40
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31732/174/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot2-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31732/112/1

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/core/31732/174/14
"curl: (6) Could not resolve host: proxy"

Restarting CI

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 59dc18c into master Aug 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the clarify-dav-cleanup-chunks branch August 3, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup