Clarify days parameter of the occ dav:cleanup-chunks command#39090
Merged
phil-davis merged 1 commit intomasterfrom Aug 3, 2021
Merged
Clarify days parameter of the occ dav:cleanup-chunks command#39090phil-davis merged 1 commit intomasterfrom
phil-davis merged 1 commit intomasterfrom
Conversation
14 tasks
JammingBen
reviewed
Aug 3, 2021
Contributor
JammingBen
left a comment
There was a problem hiding this comment.
Sounds reasonable, also matches with the official docs.
The parameter needs to be adjusted in the unit tests though.
bce7ea5 to
42ffc34
Compare
Contributor
|
💥 Acceptance tests pipeline apiProxySmoke-8-3-mariadb10.2-php7.4 failed. The build has been cancelled. |
Contributor
|
💥 Acceptance tests pipeline apiFederationToRoot2-latest-mariadb10.2-php7.4 failed. The build has been cancelled. |
Contributor
Author
|
https://drone.owncloud.com/owncloud/core/31732/174/14 Restarting CI |
|
Kudos, SonarCloud Quality Gate passed! |
JammingBen
approved these changes
Aug 3, 2021
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The days parameter of the occ dav:cleanup-chunks command is actually the minimum number of days old for cleaning up chunks. This was not 100% clear from the command help. The text and parameter name have been adjusted to say it is the minimum days.
I noticed when thinking about #39068 (comment) and how to test this command.
How Has This Been Tested?
CI and local command use.
Types of changes
Checklist: