Description

Do not try to remove the file twice while moving it to the trashbin

Related Issue

#38923

Motivation and Context

While removing a file and moving it to the trashbin, the source file or folder was deleted twice. The second call was failing because the file was already removed in the first call. This problem was ignored in the storage (which would try to remove the file again without logging the failure) and in the trashbin (ignoring the related failure).

Since the move2trash function already takes care of removing the source (for whatever reason) in case the move fails, we only need to take care of the deletion in case the trashbin isn't setup properly. In order to distinguish this case, the move2trash function will return null instead of the true. Trashbin storage is adjusted for this case.

The overall behaviour remains compatible with the previous assumptions.

How Has This Been Tested?

Manually tested following steps described in #38923

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE