X Tutup
Skip to content

Fix style and preview icon in WebUI Select Profile Picture#39067

Merged
AlexAndBear merged 2 commits intomasterfrom
enterprise/issues/4689
Jul 30, 2021
Merged

Fix style and preview icon in WebUI Select Profile Picture#39067
AlexAndBear merged 2 commits intomasterfrom
enterprise/issues/4689

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jul 28, 2021 •
edited
Loading

Description

Adjusted faulty style, fixed preview icons

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear changed the title Fix style and preview icon Fix style and preview icon in WebUI Select Profile Picture Jul 28, 2021
@AlexAndBear AlexAndBear self-assigned this Jul 28, 2021
@AlexAndBear AlexAndBear requested a review from tbsbdr July 28, 2021 07:23
tbsbdr
tbsbdr approved these changes Jul 28, 2021
View reviewed changes
Copy link

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, merci

@AlexAndBear
Copy link
Author

AlexAndBear commented Jul 28, 2021 •
edited
Loading

  • Need to check if this has an effect on the activity app, as the UI looks similar
  • Add JS tests to get CI green

@AlexAndBear AlexAndBear force-pushed the enterprise/issues/4689 branch 4 times, most recently from 4b20b60 to 043473a Compare July 29, 2021 14:13
This was referenced Jul 29, 2021
Merged
Merged
@AlexAndBear AlexAndBear force-pushed the enterprise/issues/4689 branch from 043473a to d155ca9 Compare July 30, 2021 08:01
@AlexAndBear AlexAndBear marked this pull request as ready for review July 30, 2021 08:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Jul 30, 2021
@AlexAndBear AlexAndBear merged commit 454319e into master Jul 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the enterprise/issues/4689 branch July 30, 2021 09:01
@AlexAndBear AlexAndBear mentioned this pull request Sep 21, 2021
Closed
@jnweiger
Copy link
Contributor

jnweiger commented Dec 3, 2021

Confirmed fixed in 10.9.0 beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tbsbdr tbsbdr tbsbdr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AlexAndBear AlexAndBear

@JammingBen JammingBen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexAndBear @jnweiger @tbsbdr @JammingBen
X Tutup