X Tutup
Skip to content

Log number of mounts when moving encryption keys fails #39015

Merged
IljaN merged 1 commit intomasterfrom
log-mount-count
Jul 16, 2021
Merged

Log number of mounts when moving encryption keys fails #39015
IljaN merged 1 commit intomasterfrom
log-mount-count

Conversation

@IljaN
Copy link
Contributor

@IljaN IljaN commented Jul 16, 2021

Description

Due to wrong configuration or bugs it is possible that more than one mount is returned. In this case we should log the mount-count for easier debugging.

Motivation and Context

Ease the debugging process in production-systems.

How Has This Been Tested?

More info in log-line no additional tests needed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Jul 16, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Due to wrong configuration or bugs it is possible that more than one mount is returned. In this case we
should log the mount-count for easier debugging.
@IljaN IljaN force-pushed the log-mount-count branch from c320d15 to 18c0d62 Compare July 16, 2021 08:53
@IljaN IljaN changed the title Log number of mounts Log number of mounts when moving encryption keys fails Jul 16, 2021
@IljaN IljaN self-assigned this Jul 16, 2021
@IljaN IljaN added this to the development milestone Jul 16, 2021
@IljaN IljaN requested review from AlexAndBear and JammingBen July 16, 2021 09:12
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@IljaN IljaN merged commit d329971 into master Jul 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the log-mount-count branch July 16, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup