TBD:

• Add unit tests
• Add acceptance tests [tests-only] Added acceptance tests for allow certain groups to create link share #39011
• Don't show sharing sub-tab on not matching users
• Create docs issue - done Docs for Allow public link sharing only for certain groups docs#3846
• After group delete hook to keep setting tidy

What to do about the webUI. If you are not in a group that is allowed to create public links, then you gett all the way through the "Create link share" dialog and are told "User is not in a whitelisted group".

We could check this ability when displaying the "Public Links" tab. Where it says "There are currently no link shares, you can create one" and displays the "Create public link" button, that UI could be adjusted to have no button and some different text to explain that the user can't create a public link.

@phil-davis I don't get it, the Public link tab will be hidden if you are not in a group which is allowed to share

@phil-davis I don't get it, the Public link tab will be hidden if you are not in a group which is allowed to share

I just tried it. I enabled this setting and put just the admin group in the list. Then I logged in as an ordinary user (not in admin group). When I go to share a folder, I see the Public Links tab and can try to create a public link:

@phil-davis should not work this way :/ can you try to force a cache reload ?

@phil-davis should not work this way :/ can you try to force a cache reload ?

I logged out, then ctrl-F5, logged in again. I still have the same "feature".

I highly guess that this will change the UI and will therefore be docs relevant...
In case I am right, pls file a docs issue so we can track this properly and create a docs PR when this here gets merged. Also tell if this will go into 10.8

@EParzefall fyi

@phil-davis whether @JammingBen or I am not able to reproduce it, can you have a look if there are any js errors?

@mmattel won't go in 10.8

💥 Acceptance tests pipeline apiFederationToRoot1-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31386/108/1

💥 Acceptance tests pipeline apiFederationToRoot1-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31399/109/1

💥 Acceptance tests pipeline apiFederationToRoot1-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31403/108/1

💥 Acceptance tests pipeline apiFederationToRoot1-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31404/109/1

💥 Acceptance tests pipeline apiFederationToRoot1-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31404/107/1

💥 Acceptance tests pipeline apiProxySmoke-8-1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31417/171/1

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

72.7% Coverage
0.0% Duplication