X Tutup
Skip to content

Change default sync-client-url and default-doc-base-url #38962

Merged
phil-davis merged 2 commits intomasterfrom
issues/38957
Jul 8, 2021
Merged

Change default sync-client-url and default-doc-base-url #38962
phil-davis merged 2 commits intomasterfrom
issues/38957

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jul 8, 2021 •
edited
Loading

Description

Before this PR, If the user clicks on the Desktop app button, he will be redirected to:
https://owncloud.com/download-server/#install-clients
The anchor for #install-clients seems to be missing.

With this PR we will redirect now to the client landing page:
https://owncloud.com/desktop-app/

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ownclouders
Copy link
Contributor

ownclouders commented Jul 8, 2021

💥 Acceptance tests pipeline apiShareCreateSpecialToRoot1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31030/63/1

@ownclouders
Copy link
Contributor

ownclouders commented Jul 8, 2021

💥 Acceptance tests pipeline apiWebdavProperties1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31030/101/1

@owncloud owncloud deleted a comment from update-docs bot Jul 8, 2021
@ownclouders
Copy link
Contributor

ownclouders commented Jul 8, 2021

💥 Acceptance tests pipeline cliExternalStorage-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31035/127/1

@ownclouders
Copy link
Contributor

ownclouders commented Jul 8, 2021

💥 Acceptance tests pipeline apiProxySmoke-8-6-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31036/176/1

@AlexAndBear AlexAndBear changed the title Change default sync client url Change default sync-client-url and default-doc-base-url Jul 8, 2021
@AlexAndBear AlexAndBear changed the base branch from master to release-10.8.0 July 8, 2021 14:43
@AlexAndBear AlexAndBear changed the base branch from release-10.8.0 to master July 8, 2021 14:44
phil-davis
phil-davis approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - do we want this in 10.8?

@AlexAndBear
Copy link
Author

AlexAndBear commented Jul 8, 2021

@phil-davis answer from @mmattel still pending, I guess yes. Will do a backport after this is merged to master

@ownclouders
Copy link
Contributor

ownclouders commented Jul 8, 2021

💥 Acceptance tests pipeline webUIAdminSettings-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31038/129/1

@phil-davis
Copy link
Contributor

phil-davis commented Jul 8, 2021

https://drone.owncloud.com/owncloud/core/31038/13/9
There is a unit test fail:

  1. Tests\Settings\Panels\Admin\EncryptionTest::testGetPanel

It looks like a real fail - some unit test expectation related to the code changes in this PR.

@phil-davis
Copy link
Contributor

phil-davis commented Jul 8, 2021

https://drone.owncloud.com/owncloud/core/31038/129/1

runsh: Total unexpected failed scenarios throughout the test run:
webUIAdminSettings/helpAndTips.feature:15
webUIAdminSettings/helpAndTips.feature:16
webUIAdminSettings/helpAndTips.feature:17
webUIAdminSettings/helpAndTips.feature:18
webUIAdminSettings/helpAndTips.feature:19

There are also acceptance tests that check these links - the test expectations need to be adjusted.

@phil-davis
Copy link
Contributor

phil-davis commented Jul 8, 2021

Tests have been adjusted.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 2139392 into master Jul 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/38957 branch July 8, 2021 17:14
@phil-davis phil-davis mentioned this pull request Jul 8, 2021
Merged
@phil-davis
Copy link
Contributor

phil-davis commented Jul 8, 2021

Backport to 10.8 is PR #38965

@phil-davis phil-davis mentioned this pull request Jul 9, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@pmaier1 pmaier1 Awaiting requested review from pmaier1

@mmattel mmattel Awaiting requested review from mmattel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[QA] broken links on the first login banner

3 participants

@AlexAndBear @ownclouders @phil-davis
X Tutup