X Tutup
Skip to content

Adjust PHP versions to min 7.2.5 and max <8.0.0#38934

Merged
phil-davis merged 2 commits intomasterfrom
adjust-php-versions
Jul 5, 2021
Merged

Adjust PHP versions to min 7.2.5 and max <8.0.0#38934
phil-davis merged 2 commits intomasterfrom
adjust-php-versions

Conversation

@phil-davis
Copy link
Contributor

Description

  1. PR Bump PHP dependencies 2021-06-25 #38891 had to change the min PHP version from 7.2 to 7.2.5. We need to do the same in console.php and index.php to be consistent. Anyone running PHP 7.2 should already be well past patch 5!

  2. When we first did the PHP 7.4 support, we were not 100% sure if the next annual PHP release would be 7.5 or 8.0. So we put a max version check of PHP <7.5. That looks a bit confusing now that there really is no PHP 7.5 and PHP 8.0 has been released for quite a while. The check is adjusted to be max version <8.0.0.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis requested a review from micbar July 4, 2021 06:56
@phil-davis phil-davis self-assigned this Jul 4, 2021
@owncloud owncloud deleted a comment from update-docs bot Jul 4, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit aec35a8 into master Jul 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjust-php-versions branch July 5, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup