Adjust PHP versions to min 7.2.5 and max <8.0.0#38934
Merged
phil-davis merged 2 commits intomasterfrom Jul 5, 2021
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
micbar
approved these changes
Jul 4, 2021
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Bump PHP dependencies 2021-06-25 #38891 had to change the min PHP version from 7.2 to 7.2.5. We need to do the same in
console.phpandindex.phpto be consistent. Anyone running PHP 7.2 should already be well past patch 5!When we first did the PHP 7.4 support, we were not 100% sure if the next annual PHP release would be 7.5 or 8.0. So we put a max version check of PHP <7.5. That looks a bit confusing now that there really is no PHP 7.5 and PHP 8.0 has been released for quite a while. The check is adjusted to be max version <8.0.0.
How Has This Been Tested?
CI
Types of changes
Checklist: