X Tutup
Skip to content

[tests-only] [full-ci] Fix notifications tests due to changes in notifications PR 342#38896

Merged
phil-davis merged 1 commit intomasterfrom
fix-notifications-tests
Jun 26, 2021
Merged

[tests-only] [full-ci] Fix notifications tests due to changes in notifications PR 342#38896
phil-davis merged 1 commit intomasterfrom
fix-notifications-tests

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 26, 2021

Description

Notifications PR owncloud/notifications#342 changed the link provided in notification to be a full absolute URL.

Some test in core were effected. See demonstration PR #38895

This PR adjusts the expected link format in the test scenarios to match the new absolute URLs.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jun 26, 2021
AlexAndBear
AlexAndBear approved these changes Jun 26, 2021
View reviewed changes
Copy link

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 26, 2021 •
edited
Loading

Note: this will also be needed in release-10.8.0 branch, so that CI will pass there with the latest notifications app code.

See #38897

@phil-davis phil-davis mentioned this pull request Jun 26, 2021
Merged
11 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 524aaca into master Jun 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-notifications-tests branch June 26, 2021 14:54
This was referenced Jun 26, 2021
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JammingBen JammingBen Awaiting requested review from JammingBen

1 more reviewer

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phil-davis phil-davis

Labels

QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @AlexAndBear
X Tutup