Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Updated old changelog

💥 Acceptance tests pipeline webUISharingPublic1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30807/149/1

💥 Acceptance tests pipeline webUISharingPublic1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30808/149/1

TBD fix tests

💥 Acceptance tests pipeline webUISharingPublic1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30809/149/1

💥 Acceptance tests pipeline apiSharingNotificationsToRoot-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30811/104/1

💥 Acceptance tests pipeline apiSharingNotificationsToShares-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30811/105/1

https://drone.owncloud.com/owncloud/core/30811/105/13

 Scenario: share to user sends notification                                                            # /drone/src/tests/acceptance/features/apiSharingNotificationsToShares/sharingNotifications.feature:25
    Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                     # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/textfile0.txt"                # FeatureContext::userHasUploadedAFileTo()
    When user "Alice" shares folder "/PARENT" with user "Brian" using the sharing API                   # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    And user "Alice" shares file "/textfile0.txt" with user "Brian" using the sharing API               # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    Then user "Brian" should have 2 notifications                                                       # NotificationsCoreContext::userNumNotifications()
    And the last notification of user "Brian" should match these regular expressions about user "Alice" # NotificationsCoreContext::matchNotificationRegularExpression()
      | key         | regex                                            |
      | app         | /^files_sharing$/                                |
      | subject     | /^"%displayname%" shared "PARENT" with you$/     |
      | message     | /^"%displayname%" invited you to view "PARENT"$/ |
      | link        | /^(\/index\.php)?\/f\/(\d+)$/                    |
      | object_type | /^local_share$/                                  |
      '/^(\/index\.php)?\/f\/(\d+)$/' does not match 'https://server/f/2147483661'
      Failed asserting that false is not false.

I suspect that notifications PR owncloud/notifications#342 has changed the link reported in a notification.

Investigating in #38895

@phil-davis thanks, yes this is desired, notifications include relative links (only the API will response with (concatenated) absolute link.

@janackermann #38896 has been merged.

Please rebase this PR

@phil-davis thanks 👍 rebased

@mmatel Docs relevant ?

God damned, now Sonarcloud complains :/

I added a commit to exclude all the template files from SonarCloud coverage calculations. IMO there is "no such thing" as unit tests for those.

Maybe the files to be included/excluded for coverage calculations needs to be refined more. But this will hopefully make SonarCloud happy with this PR.

💥 Acceptance tests pipeline apiAuthOcs-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30818/53/1

💥 Acceptance tests pipeline apiAuth-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30818/52/1

💥 Acceptance tests pipeline apiCapabilities-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30818/55/1

This PR is cursed 👻

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

@phil-davis still fails :/

@janackermann is this really still Draft?

@micbar IMO the SonarCloud change here is fine. But we still need to do more to sort out exactly what to do about this sort of PR. It's up to you to decide if you override and merge.

SonarCloud: https://sonarcloud.io/component_measures?id=owncloud_core&metric=new_coverage&pullRequest=38894&selected=owncloud_core%3Aapps%2Ffiles_sharing%2Fjs%2Fauthenticate.js&view=list

It is complaining about authenticate.js not have unit test coverage.

@phil-davis Converted to ready-to-review