X Tutup
Skip to content

Fix acceptance tests#38889

Merged
AlexAndBear merged 2 commits intomasterfrom
fix-files-sharing-activity-tests
Jun 24, 2021
Merged

Fix acceptance tests#38889
AlexAndBear merged 2 commits intomasterfrom
fix-files-sharing-activity-tests

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jun 24, 2021 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear requested a review from phil-davis June 24, 2021 11:26
phil-davis
phil-davis reviewed Jun 24, 2021
View reviewed changes
@AlexAndBear AlexAndBear force-pushed the fix-files-sharing-activity-tests branch from d17109f to cc89960 Compare June 24, 2021 11:28
@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline apiCapabilities-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30797/55/1

@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline apiProvisioningGroups-v2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30797/62/1

@AlexAndBear AlexAndBear requested a review from phil-davis June 24, 2021 11:29
@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline cliExternalStorage-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30797/126/1

@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline webUIMoveFilesFolder-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30797/136/1

@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline apiWebdavLocks-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30797/92/1

@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline webUISharingExt2-latest-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30797/162/1

@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline apiProxySmoke-8-6-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30797/175/1

@AlexAndBear
Copy link
Author

AlexAndBear commented Jun 24, 2021

@phil-davis we added a new subjectparam that's why we ran in the == 2 check was not fulfilled and the wrong text was rendered

@AlexAndBear AlexAndBear requested a review from JammingBen June 24, 2021 11:30
@AlexAndBear AlexAndBear self-assigned this Jun 24, 2021
phil-davis
phil-davis approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JammingBen
JammingBen suggested changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do the same in translateShort():

core/apps/files_sharing/lib/Activity.php

Line 313 in cc89960

if (\sizeof($params) === 2) {

@AlexAndBear AlexAndBear requested a review from JammingBen June 24, 2021 11:37
@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline apiMain-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30800/58/1

@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline apiTrashbin-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30800/88/1

@ownclouders
Copy link
Contributor

ownclouders commented Jun 24, 2021

💥 Acceptance tests pipeline apiFederationToRoot2-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/30800/109/1

@owncloud owncloud deleted a comment from update-docs bot Jun 24, 2021
@phil-davis phil-davis self-requested a review June 24, 2021 11:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 3939600 into master Jun 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-files-sharing-activity-tests branch June 24, 2021 12:55
@phil-davis
Copy link
Contributor

phil-davis commented Jun 25, 2021

Activity CI passed last night 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

+1 more reviewer

@JammingBen JammingBen JammingBen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AlexAndBear AlexAndBear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI failing for some federated share tests

4 participants

@AlexAndBear @ownclouders @phil-davis @JammingBen
X Tutup